Merged
Conversation
Contributor
|
Great job! BTW, it will create big conflict with my PR. I'll need to manually merge it. |
Contributor
There was a problem hiding this comment.
Maybe it is good to start to handle different error, for exemple the JsonSyntaxException, imagine in my request i send Yo died, then i will get a 500, maybe we can catch this and return a proper http code like 400 Bad Request
3 tasks
Contributor
|
Tested, works great! |
Contributor
Author
|
Thanks for taking care of the conflict! |
Contributor
|
@minahlee This is really useful improvements. Great work. |
minahlee
force-pushed
the
add/interpreter_edit
branch
from
764ab2b to
6e2c9a7
Compare
Contributor
|
Tested and Looks good to me! |
Leemoonsoo
added a commit
that referenced
this pull request
Feb 17, 2015
Enable interpreter properties edit
epahomov
pushed a commit
to epahomov/zeppelin
that referenced
this pull request
Jul 23, 2016
Author: Antoine Augusti <AntoineAugusti@users.noreply.github.com> Closes ZEPL#330 from AntoineAugusti/patch-1 and squashes the following commits: 55c702b [Antoine Augusti] Fix typo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables you to edit interpreter setting properties.